Include cargo.lock.#224
Closed
dcampbell24 wants to merge 1 commit intosmol-rs:masterfrom
dcampbell24:include-cargo-lock
Closed
Include cargo.lock.#224dcampbell24 wants to merge 1 commit intosmol-rs:masterfrom dcampbell24:include-cargo-lock
dcampbell24 wants to merge 1 commit intosmol-rs:masterfrom
dcampbell24:include-cargo-lock
Conversation
See https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control for the reasons why.
Contributor
Author
|
I thought this might fix the build error, but I was wrong. Because this is a library maybe you should not include cargo.lock. |
Collaborator
|
The current CI error is upstream issue and will be fixed in next nightly (rust-lang/rust#140734). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control for the reasons why.